Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Backport PR #16482 to 8.x: Bugfix for BufferedTokenizer" #16714

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

donoghuc
Copy link
Member

Release notes

What does this PR do?

Reverts #16482, as applied to 8.x

Why is it important/What is the impact to the user?

Strings handled by the buffered tokenizer could be double-encoded, presenting problems.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

…r to completely consume lines in case of lines bigger then sizeLimit (elastic#16569)"

This reverts commit 27bd2a0.
@donoghuc donoghuc changed the title Revert "Backport PR #16482 to 8.x: Bugfix for BufferedTokenizer to co… Revert "Backport PR #16482 to 8.x: Bugfix for BufferedTokenizer Nov 21, 2024
@donoghuc donoghuc changed the title Revert "Backport PR #16482 to 8.x: Bugfix for BufferedTokenizer Revert "Backport PR #16482 to 8.x: Bugfix for BufferedTokenizer" Nov 21, 2024
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge once CI is green.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@donoghuc donoghuc merged commit 03d57a1 into elastic:8.x Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants