Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing out co behavior #203931

Closed
wants to merge 1 commit into from
Closed

testing out co behavior #203931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ packages/kbn-ci-stats-reporter @elastic/kibana-operations
packages/kbn-ci-stats-shipper-cli @elastic/kibana-operations
packages/kbn-cli-dev-mode @elastic/kibana-operations
packages/kbn-code-owners @elastic/appex-qa
packages/kbn-coloring @elastic/kibana-visualizations
packages/kbn-coloring @elastic/kibana-core
packages/kbn-config @elastic/kibana-core
packages/kbn-config-mocks @elastic/kibana-core
packages/kbn-config-schema @elastic/kibana-core
Expand Down Expand Up @@ -3383,6 +3383,8 @@ x-pack/solutions/security/plugins/session_view @elastic/kibana-cloud-security-po
x-pack/solutions/security/plugins/threat_intelligence @elastic/security-threat-hunting-investigations
x-pack/solutions/security/plugins/timelines @elastic/security-threat-hunting-investigations

test-nick @elastic/kibana-visualizations

####
## These rules are always last so they take ultimate priority over everything else
####
3 changes: 2 additions & 1 deletion packages/kbn-coloring/src/shared_components/color_mapping/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ This package provides:
- a function `getColorFactory` that given a color mapping configuration returns a function that maps a passed category to the corresponding color
- a definition scheme for the color mapping, based on the type `ColorMapping.Config`, that provides an extensible way of describing the link between colors and rules. Collects the minimal information required apply colors based on categories. Together with the `ColorMappingInputData` can be used to get colors in a deterministic way.

Testing

An example of the configuration is the following:
```ts
Expand Down Expand Up @@ -84,4 +85,4 @@ function CategoricalColorMapping(props: {

```

the `onModelUpdate` callback is called everytime a change in the model is applied from within the component. Is not called when the `model` prop is updated.
the `onModelUpdate` callback is called everytime a change in the model is applied from within the component. Is not called when the `model` prop is updated.
1 change: 1 addition & 0 deletions test-nick/some_file.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Testing this