Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Update all CODEOWNER paths to new destinations #203682

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Dec 10, 2024

Summary

TLDR; This adds new sustainable kibana file destinations to .github/CODEOWNER so they correctly show in PRs making PR review much easier on teams.

GitHub does not update the CODEOWNER for PRs when files are moved while also updating that files path in the .github/CODEOWNERS file to the new path. Even worse, this also applies to files that were moved and have code changes. See example of this here.

testing mv files w old CO path by nickofthyme · Pull Request #203659 · elastickibana 2024-12-10 at 12 28 11 PM

Notice the missing CO badge in the screenshot above. All these files should show they are owned my @elastic/kibana-visualizations, as that is the new file destination. Not only is the badge missing, but these files are excluded when filtering files by CO only.

This PR coalesces all additions to .github/CODEOWNERS across all sustainable kibana PRs. This excludes code removals, only adding new destinations. Old destinations to be removed in respective PRs.

In git terms...

git checkout gsoldevila/kbn-team-1309-move-kibana-security-solution -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-obs-ux-management-team -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-security-generative-ai -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-security-threat-hunting-explore -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-stack-monitoring -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-streams-program-team -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-security-threat-hunting -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-security-detection-rule-management -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-obs-ux-logs-team -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-cloud-security-posture -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-security-detection-engine -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-security-defend-workflows -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-obs-ai-assistant -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-packages-core -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-response-ops -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-operations -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-core-packages-1-10 -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-obs-ux-infra_services-team -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-security-threat-hunting-investigations -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-x-pack-packages-security-solution -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-security-scalability -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-observability-ui -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-security-detections-response -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-visualizations -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-logstash -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-obs-knowledge-team -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-reporting-services -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-search-kibana -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-security -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-presentation -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-fleet -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-appex-sharedux -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-data-discovery -- .github/CODEOWNERS
git checkout gsoldevila/kbn-team-1309-move-kibana-management -- .github/CODEOWNERS

@nickofthyme nickofthyme changed the title Sustainable Kibana Architecture: Update all CODEOWNER paths to new destinations Sustainable Kibana Architecture: Update all CODEOWNER paths to new destinations Dec 10, 2024
@nickofthyme nickofthyme added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 10, 2024
@nickofthyme nickofthyme requested review from a team as code owners December 10, 2024 20:21
.github/CODEOWNERS Outdated Show resolved Hide resolved
@nickofthyme nickofthyme removed request for a team December 10, 2024 21:08
Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🚀

@nickofthyme nickofthyme enabled auto-merge (squash) December 11, 2024 17:53
@nickofthyme nickofthyme merged commit 122a8d2 into elastic:main Dec 11, 2024
8 checks passed
@nickofthyme nickofthyme deleted the sus-kib-co-changes branch December 11, 2024 18:59
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants