-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Reduce number of histogram updates #200074
Conversation
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7399[✅] test/functional/apps/discover/group3/config.ts: 25/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7398[✅] test/functional/apps/discover/group3/config.ts: 50/50 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7401[✅] test/functional/apps/discover/group3/config.ts: 100/100 tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I tested this PR and when I tried to reproduce
Moving from an initial data view without timefield to one with timefield, on this instance
https://kertal-pr-200074-fix-histogram.kbndev.co/app/r/s/sWisD
I no longer had error message, which makes me consider if this could be already part of
WDYT? @jughosta ... however, due to the flaky nature of these problems, it could be the case that it just works/fails for me
@kertal While it reduces the number of |
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers