Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ownership] Assign test files to platform security team #199795

Merged
merged 16 commits into from
Nov 18, 2024
Merged

[Ownership] Assign test files to platform security team #199795

Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
158e659
[Ownership] Assign test files to platform security team
wayneseymour Nov 12, 2024
cacee35
fixup
wayneseymour Nov 12, 2024
ae80bb2
updated per other pr review
wayneseymour Nov 12, 2024
436c9bc
drop per cr
wayneseymour Nov 13, 2024
c265851
change per cr
wayneseymour Nov 13, 2024
c15b90c
Merge branch 'main' into assign-platform-security
elasticmachine Nov 18, 2024
329f07d
more
wayneseymour Nov 18, 2024
f439f5e
Merge branch 'main' of github.com:elastic/kibana into assign-platform…
wayneseymour Nov 18, 2024
ff8ee3f
Merge branch 'assign-platform-security' of github.com:elastic/kibana …
wayneseymour Nov 18, 2024
21ca379
drop
wayneseymour Nov 18, 2024
eb53ee0
Merge branch 'main' of github.com:elastic/kibana into assign-platform…
wayneseymour Nov 18, 2024
5f41777
add co-ownership with core
wayneseymour Nov 18, 2024
894a8ed
assign more
wayneseymour Nov 18, 2024
0f16b02
Apply suggestions from code review
wayneseymour Nov 18, 2024
e05256d
re-assign to core
wayneseymour Nov 18, 2024
c55ced3
Merge branch 'assign-platform-security' of github.com:elastic/kibana …
wayneseymour Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1479,6 +1479,27 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib
#CC# /x-pack/plugins/translations/ @elastic/kibana-localization @elastic/kibana-core

# Kibana Platform Security
# security
/x-pack/test/functional/es_archives/rule_exceptions @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199797#discussion_r1838166357
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/x-pack/test_serverless/functional/test_suites/observability/role_management @elastic/kibana-security
/x-pack/test/functional/config_security_basic.ts @elastic/kibana-security
/x-pack/test/functional/page_objects/user_profile_page.ts @elastic/kibana-security
/x-pack/test/functional/page_objects/space_selector_page.ts @elastic/kibana-security
/x-pack/test/functional/page_objects/security_page.ts @elastic/kibana-security
/x-pack/test/functional/page_objects/role_mappings_page.ts @elastic/kibana-security
/x-pack/test/functional/page_objects/copy_saved_objects_to_space_page.ts @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/39002
/x-pack/test/functional/page_objects/api_keys_page.ts @elastic/kibana-security
/x-pack/test/functional/page_objects/account_settings_page.ts @elastic/kibana-security
/x-pack/test/functional/apps/user_profiles @elastic/kibana-security
/x-pack/test/common/services/spaces.ts @elastic/kibana-security
/x-pack/test/api_integration/config_security_*.ts @elastic/kibana-security
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/x-pack/test/functional/apps/api_keys @elastic/kibana-security
/x-pack/test/ftr_apis @elastic/kibana-security
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/test/server_integration/services/supertest.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/test/server_integration/http/ssl @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810
/test/server_integration/config.base.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810
/test/server_integration/__fixtures__ @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like most of these were introduced by @elastic/kibana-core in #19261. That said, there is certainly some overlap with our team. I think we'd be ok will owing or having joint ownership of some of these (ssl folders & fixtures folder to be specific), but we should check with core first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-core can someone weigh in here pretty please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked in slack

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think on the whole security would be a better reviewer if we do ever change anything SSL related so it'd make sense to me for them to own it.

Core could be a co-owner of /test/server_integration/config.base.js and I think it makes the most sense for us to own test/server_integration/http/ssl_redirect/index.ts

I think security should also own the other ssl* folders like ssl_with_p12 and ssl_with_p12_intermediate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think security should also own the other ssl* folders like ssl_with_p12 and ssl_with_p12_intermediate

++

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5f41777 && 894a8ed

/x-pack/test/plugin_api_integration/plugins/feature_usage_test @elastic/kibana-security
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/.github/codeql @elastic/kibana-security
/.github/workflows/codeql.yml @elastic/kibana-security
/.github/workflows/codeql-stats.yml @elastic/kibana-security
Expand Down