From 158e659d821cc717e268c8ce5bc83bb3336ad955 Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Tue, 12 Nov 2024 13:47:16 +0000 Subject: [PATCH 01/11] [Ownership] Assign test files to platform security team --- .github/CODEOWNERS | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ef265cf7c569a..d4eae36aba5a1 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1479,6 +1479,27 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib #CC# /x-pack/plugins/translations/ @elastic/kibana-localization @elastic/kibana-core # Kibana Platform Security +# security +/ @elastic/kibana-security +/x-pack/test_serverless/functional/test_suites/observability/role_management @elastic/kibana-security +/x-pack/test/functional/config_security_basic.ts @elastic/kibana-security +/x-pack/test/functional/page_objects/user_profile_page.ts @elastic/kibana-security +/x-pack/test/functional/page_objects/space_selector_page.ts @elastic/kibana-security +/x-pack/test/functional/page_objects/security_page.ts @elastic/kibana-security +/x-pack/test/functional/page_objects/role_mappings_page.ts @elastic/kibana-security +/x-pack/test/functional/page_objects/copy_saved_objects_to_space_page.ts @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/39002 +/x-pack/test/functional/page_objects/api_keys_page.ts @elastic/kibana-security +/x-pack/test/functional/page_objects/account_settings_page.ts @elastic/kibana-security +/x-pack/test/functional/apps/user_profiles @elastic/kibana-security +/x-pack/test/common/services/spaces.ts @elastic/kibana-security +/x-pack/test/api_integration/config_security_*.ts @elastic/kibana-security +/x-pack/test/functional/apps/api_keys @elastic/kibana-security +/x-pack/test/ftr_apis @elastic/kibana-security +/test/server_integration/services/supertest.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 +/test/server_integration/http/ssl @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 +/test/server_integration/config.base.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 +/test/server_integration/__fixtures__ @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 +/x-pack/test/plugin_api_integration/plugins/feature_usage_test @elastic/kibana-security /.github/codeql @elastic/kibana-security /.github/workflows/codeql.yml @elastic/kibana-security /.github/workflows/codeql-stats.yml @elastic/kibana-security From cacee35cccd4ac9a64043fa62c3a7b37e3999f82 Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Tue, 12 Nov 2024 13:49:23 +0000 Subject: [PATCH 02/11] fixup --- .github/CODEOWNERS | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index d4eae36aba5a1..4eeff98f04d70 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1480,7 +1480,6 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib # Kibana Platform Security # security -/ @elastic/kibana-security /x-pack/test_serverless/functional/test_suites/observability/role_management @elastic/kibana-security /x-pack/test/functional/config_security_basic.ts @elastic/kibana-security /x-pack/test/functional/page_objects/user_profile_page.ts @elastic/kibana-security From ae80bb252bc71f787c122849fcb9b01e386fc5e9 Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Tue, 12 Nov 2024 16:09:52 +0000 Subject: [PATCH 03/11] updated per other pr review --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 4eeff98f04d70..f637eeeec862f 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1480,6 +1480,7 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib # Kibana Platform Security # security +/x-pack/test/functional/es_archives/rule_exceptions @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199797#discussion_r1838166357 /x-pack/test_serverless/functional/test_suites/observability/role_management @elastic/kibana-security /x-pack/test/functional/config_security_basic.ts @elastic/kibana-security /x-pack/test/functional/page_objects/user_profile_page.ts @elastic/kibana-security From 436c9bc06c533130676000417774065bd1e93a50 Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Wed, 13 Nov 2024 14:10:47 +0000 Subject: [PATCH 04/11] drop per cr --- .github/CODEOWNERS | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index f637eeeec862f..4eeff98f04d70 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1480,7 +1480,6 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib # Kibana Platform Security # security -/x-pack/test/functional/es_archives/rule_exceptions @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199797#discussion_r1838166357 /x-pack/test_serverless/functional/test_suites/observability/role_management @elastic/kibana-security /x-pack/test/functional/config_security_basic.ts @elastic/kibana-security /x-pack/test/functional/page_objects/user_profile_page.ts @elastic/kibana-security From c2658512f7df7aa08df5806956dfd54ef0f544e0 Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Wed, 13 Nov 2024 14:16:20 +0000 Subject: [PATCH 05/11] change per cr --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 4eeff98f04d70..dd2fee38b6e2f 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1493,7 +1493,7 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib /x-pack/test/common/services/spaces.ts @elastic/kibana-security /x-pack/test/api_integration/config_security_*.ts @elastic/kibana-security /x-pack/test/functional/apps/api_keys @elastic/kibana-security -/x-pack/test/ftr_apis @elastic/kibana-security +/x-pack/test/ftr_apis/security_and_spaces @elastic/kibana-security /test/server_integration/services/supertest.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 /test/server_integration/http/ssl @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 /test/server_integration/config.base.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 From 329f07dfe94e5a2e727710c82c6329efecbd2853 Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Mon, 18 Nov 2024 10:42:29 +0000 Subject: [PATCH 06/11] more --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index dd2fee38b6e2f..3f8a2cc71d72b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1480,6 +1480,7 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib # Kibana Platform Security # security +/test/api_integration/apis/general/*.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199767#discussion_r1840492130 /x-pack/test_serverless/functional/test_suites/observability/role_management @elastic/kibana-security /x-pack/test/functional/config_security_basic.ts @elastic/kibana-security /x-pack/test/functional/page_objects/user_profile_page.ts @elastic/kibana-security From 21ca379908f35e50c28725e6cee04d592123caf5 Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Mon, 18 Nov 2024 10:47:30 +0000 Subject: [PATCH 07/11] drop --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 25c8c50601340..f36ac4c8b1c5a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1542,6 +1542,7 @@ x-pack/test/api_integration/deployment_agnostic/services/ @elastic/appex-qa x-pack/test/**/deployment_agnostic/ @elastic/appex-qa #temporarily to monitor tests migration # Core +/x-pack/test/plugin_api_integration/plugins/feature_usage_test @elastic/kibana-core /test/plugin_functional/plugins/rendering_plugin @elastic/kibana-core /test/plugin_functional/plugins/session_notifications @elastic/kibana-core /x-pack/test/cloud_integration/plugins/saml_provider @elastic/kibana-core @@ -1618,7 +1619,6 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib /test/server_integration/http/ssl @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 /test/server_integration/config.base.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 /test/server_integration/__fixtures__ @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 -/x-pack/test/plugin_api_integration/plugins/feature_usage_test @elastic/kibana-security /.github/codeql @elastic/kibana-security /.github/workflows/codeql.yml @elastic/kibana-security /.github/workflows/codeql-stats.yml @elastic/kibana-security From 5f41777673f17cef81611c40d832fc42ba65a2de Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Mon, 18 Nov 2024 12:45:06 +0000 Subject: [PATCH 08/11] add co-ownership with core --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 2a66f01f47baa..36c9b7b21d8bc 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1651,7 +1651,7 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib /x-pack/test/ftr_apis/security_and_spaces @elastic/kibana-security /test/server_integration/services/supertest.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 /test/server_integration/http/ssl @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 -/test/server_integration/config.base.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 +/test/server_integration/config.base.js @elastic/kibana-security @elastic/kibana-core # Assigned per https://github.com/elastic/kibana/pull/199795#discussion_r1846510782 /test/server_integration/__fixtures__ @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 /.github/codeql @elastic/kibana-security /.github/workflows/codeql.yml @elastic/kibana-security From 894a8ede3f9d0398c5af56bf5a82654a9bc0610b Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Mon, 18 Nov 2024 12:49:44 +0000 Subject: [PATCH 09/11] assign more --- .github/CODEOWNERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 36c9b7b21d8bc..ddbb94c64f7e9 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1651,6 +1651,9 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib /x-pack/test/ftr_apis/security_and_spaces @elastic/kibana-security /test/server_integration/services/supertest.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 /test/server_integration/http/ssl @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 +/test/server_integration/http/ssl_with_p12 @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199795#discussion_r1846522206 +/test/server_integration/http/ssl_with_p12_intermediate @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199795#discussion_r1846522206 + /test/server_integration/config.base.js @elastic/kibana-security @elastic/kibana-core # Assigned per https://github.com/elastic/kibana/pull/199795#discussion_r1846510782 /test/server_integration/__fixtures__ @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 /.github/codeql @elastic/kibana-security From 0f16b020f135cb09a0d805b31bfd6b4acbaca61d Mon Sep 17 00:00:00 2001 From: Tre Date: Mon, 18 Nov 2024 14:35:37 +0000 Subject: [PATCH 10/11] Apply suggestions from code review Co-authored-by: Jeramy Soucy --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ddbb94c64f7e9..40e0b5a5d533a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1649,7 +1649,7 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib /x-pack/test/api_integration/config_security_*.ts @elastic/kibana-security /x-pack/test/functional/apps/api_keys @elastic/kibana-security /x-pack/test/ftr_apis/security_and_spaces @elastic/kibana-security -/test/server_integration/services/supertest.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 +/test/server_integration/services/supertest.js @elastic/kibana-security @elastic/kibana-core /test/server_integration/http/ssl @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 /test/server_integration/http/ssl_with_p12 @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199795#discussion_r1846522206 /test/server_integration/http/ssl_with_p12_intermediate @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199795#discussion_r1846522206 From e05256ddb55d75919a26d40525f661e403c30564 Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Mon, 18 Nov 2024 14:37:20 +0000 Subject: [PATCH 11/11] re-assign to core --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ddbb94c64f7e9..e60fdb4c4ed15 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1576,6 +1576,7 @@ x-pack/test/api_integration/deployment_agnostic/services/ @elastic/appex-qa x-pack/test/**/deployment_agnostic/ @elastic/appex-qa #temporarily to monitor tests migration # Core +/test/api_integration/apis/general/*.js @elastic/kibana-core # Assigned per https://github.com/elastic/kibana/pull/199795/files/894a8ede3f9d0398c5af56bf5a82654a9bc0610b#r1846691639 /x-pack/test/plugin_api_integration/plugins/feature_usage_test @elastic/kibana-core /test/plugin_functional/plugins/rendering_plugin @elastic/kibana-core /test/plugin_functional/plugins/session_notifications @elastic/kibana-core @@ -1634,7 +1635,6 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib # Kibana Platform Security # security -/test/api_integration/apis/general/*.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199767#discussion_r1840492130 /x-pack/test_serverless/functional/test_suites/observability/role_management @elastic/kibana-security /x-pack/test/functional/config_security_basic.ts @elastic/kibana-security /x-pack/test/functional/page_objects/user_profile_page.ts @elastic/kibana-security