Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability Onboarding] Display next steps #197179

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Oct 22, 2024

Summary

Display next steps after the auto-detect script completes.

Screenshot

Screenshot 2024-10-22 at 09 30 51

@thomheymann thomheymann added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v9.0.0 labels Oct 22, 2024
@thomheymann thomheymann marked this pull request as ready for review October 22, 2024 13:57
@thomheymann thomheymann requested review from a team as code owners October 22, 2024 13:57
@thomheymann thomheymann added the release_note:skip Skip the PR/issue when compiling release notes label Oct 22, 2024
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM 🚀

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 81d93c1
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197179-81d93c10aca1

Metrics [docs]

✅ unchanged

History

Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything works as expected ✨

@thomheymann thomheymann merged commit 48959e7 into elastic:main Oct 24, 2024
27 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11501703788

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 197179

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197179 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197179 locally

gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Oct 30, 2024
## Summary

Display next steps after the auto-detect script completes.

## Screenshot

<img width="905" alt="Screenshot 2024-10-22 at 09 30 51"
src="https://github.com/user-attachments/assets/85108ea2-510a-46f7-8b79-135be91b586f">

(cherry picked from commit 48959e7)

# Conflicts:
#	x-pack/plugins/observability_solution/observability_onboarding/server/routes/flow/route.ts
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

7 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@gbamparop
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

cc @thomheymann

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@thomheymann
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

thomheymann added a commit to thomheymann/kibana that referenced this pull request Nov 14, 2024
## Summary

Display next steps after the auto-detect script completes.

## Screenshot

<img width="905" alt="Screenshot 2024-10-22 at 09 30 51"
src="https://github.com/user-attachments/assets/85108ea2-510a-46f7-8b79-135be91b586f">

(cherry picked from commit 48959e7)

# Conflicts:
#	x-pack/plugins/observability_solution/observability_onboarding/server/routes/flow/route.ts
#	x-pack/plugins/observability_solution/observability_onboarding/server/routes/types.ts
thomheymann added a commit that referenced this pull request Nov 14, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Observability Onboarding] Display next steps
(#197179)](#197179)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thom
Heymann","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T14:43:01Z","message":"[Observability
Onboarding] Display next steps (#197179)\n\n## Summary\r\n\r\nDisplay
next steps after the auto-detect script completes.\r\n\r\n##
Screenshot\r\n\r\n<img width=\"905\" alt=\"Screenshot 2024-10-22 at 09
30
51\"\r\nsrc=\"https://github.com/user-attachments/assets/85108ea2-510a-46f7-8b79-135be91b586f\">","sha":"48959e769cb29b02e8c49d68fb2c7f9f8c3418d0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","Team:Fleet","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"number":197179,"url":"https://github.com/elastic/kibana/pull/197179","mergeCommit":{"message":"[Observability
Onboarding] Display next steps (#197179)\n\n## Summary\r\n\r\nDisplay
next steps after the auto-detect script completes.\r\n\r\n##
Screenshot\r\n\r\n<img width=\"905\" alt=\"Screenshot 2024-10-22 at 09
30
51\"\r\nsrc=\"https://github.com/user-attachments/assets/85108ea2-510a-46f7-8b79-135be91b586f\">","sha":"48959e769cb29b02e8c49d68fb2c7f9f8c3418d0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197179","number":197179,"mergeCommit":{"message":"[Observability
Onboarding] Display next steps (#197179)\n\n## Summary\r\n\r\nDisplay
next steps after the auto-detect script completes.\r\n\r\n##
Screenshot\r\n\r\n<img width=\"905\" alt=\"Screenshot 2024-10-22 at 09
30
51\"\r\nsrc=\"https://github.com/user-attachments/assets/85108ea2-510a-46f7-8b79-135be91b586f\">","sha":"48959e769cb29b02e8c49d68fb2c7f9f8c3418d0"}},{"url":"https://github.com/elastic/kibana/pull/198267","number":198267,"branch":"8.x","state":"OPEN"}]}]
BACKPORT-->
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@gbamparop
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@thomheymann do you know why this is still happening after the backport was merged?

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

gbamparop added a commit that referenced this pull request Nov 25, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
 - [Observability Onboarding] Display next steps (#197179) (48959e7)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thom
Heymann","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T14:43:01Z","message":"[Observability
Onboarding] Display next steps (#197179)\n\n## Summary\r\n\r\nDisplay
next steps after the auto-detect script completes.\r\n\r\n##
Screenshot\r\n\r\n<img width=\"905\" alt=\"Screenshot 2024-10-22 at 09
30
51\"\r\nsrc=\"https://github.com/user-attachments/assets/85108ea2-510a-46f7-8b79-135be91b586f\">","sha":"48959e769cb29b02e8c49d68fb2c7f9f8c3418d0"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}]
BACKPORT-->

Co-authored-by: Thom Heymann <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Mykola Harmash <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants