Skip to content

Commit

Permalink
fix: kibana dev server not restarting for external plugin #171260 (#1…
Browse files Browse the repository at this point in the history
…98246)

## Summary

Fixes #171260 the Kibana dev server not restarting during external
plugin development for server side code.

### Checklist


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Release note
Fixes #171260 the Kibana dev server not restarting during external
plugin development for server side code.

---------

Co-authored-by: Brad White <[email protected]>
  • Loading branch information
mickalpine and Ikuni17 authored Nov 20, 2024
1 parent 393ffa5 commit 83b282a
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion packages/kbn-cli-dev-mode/src/watcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ const packageMatcher = makeMatcher([
/**
* Any code that is outside of a package must match this in order to trigger a restart
*/
const nonPackageMatcher = makeMatcher(['config/**/*.yml']);
const nonPackageMatcher = makeMatcher(['config/**/*.yml', 'plugins/**/server/**/*']);
const staticFileMatcher = makeMatcher(['plugins/**/kibana.json']);

export interface Options {
enabled: boolean;
Expand Down Expand Up @@ -87,6 +88,10 @@ export class Watcher {
if (result.type === 'non-package') {
return nonPackageMatcher(result.repoRel) && fire(result.repoRel);
}

if (result.type === 'static') {
return staticFileMatcher(result.repoRel) && fire(result.repoRel);
}
}
},
{
Expand Down

0 comments on commit 83b282a

Please sign in to comment.