change formatError to not set ecsFields.err
if the given err
isn't an Error
#66
Labels
agent-nodejs
Make available for APM Agents project planning.
Currently
formatError
in the helpers package does this:I.e. if
err
is an Error, then it will fill inecsFields.error
. Otherwise it will setecsFields.err
. But "err" isn't a spec'd ECS field, so it shouldn't do that. It should be up to the callers to handle this. This would also better match formatHttpRequest and formatHttpResponse which do not setecsFields.req
or.res
if they cannot process the given value.This will be a breaking change.
The text was updated successfully, but these errors were encountered: