Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo owner detection breaks for repos containing . in their name #431

Open
benhiller opened this issue Dec 6, 2024 · 0 comments
Open

Repo owner detection breaks for repos containing . in their name #431

benhiller opened this issue Dec 6, 2024 · 0 comments

Comments

@benhiller
Copy link

I tried using spr with a repo, but git spr status failed with the error: unable to auto configure repository owner - must be set manually in .spr.yml.

I believe the issue is because the repo name contains ., and repoFormat only allows \w and -. This is sort of a similar issue to the one fixed in https://github.com/ejoffe/spr/pull/393/files.

Creating a repo on Github shows that it allows: "ASCII letters, digits, and the characters ., -, and _" in repo names. Would it be reasonable to modify the regex to match all of those? Maybe adding . would cause issues with matching the .git suffix though.

Screenshot 2024-12-05 at 4 35 26 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant