Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message on PR descriptions needs an update #404

Open
FabriceCastel opened this issue May 2, 2024 · 0 comments
Open

Warning message on PR descriptions needs an update #404

FabriceCastel opened this issue May 2, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@FabriceCastel
Copy link

It seems that it is in fact FINE to:

  • merge the lowest PR in the stack through the GitHub UI
  • run git spr update
  • proceed as usual

I assume the way things can go "bad" is if you accidentally merge a branch that's targeting one of the automatically created spr branches instead of main, for example.

The error message that gets tacked on at the end of PR messages should be updated to reflect this. Either of the following seems reasonable to me:

  • omit the message entirely for the lowest PR in the stack
  • update the message to explain what github UI merge opterations do or do not break the expected flow with spr
@chriscz chriscz added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants