Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub star on Enterprise #386

Open
piefel opened this issue Jan 18, 2024 · 4 comments
Open

GitHub star on Enterprise #386

piefel opened this issue Jan 18, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@piefel
Copy link

piefel commented Jan 18, 2024

Since I’m on a Github Enterprise server, the star redirect fails with a stack trace:

enjoying git spr? add a GitHub star? [Y/n]:
panic: repository: Could not resolve to a Repository with the name 'ejoffe/spr'.
[…]

@ejoffe
Copy link
Owner

ejoffe commented Jan 18, 2024

What version of spr are you using?

@piefel
Copy link
Author

piefel commented Jan 19, 2024

Don’t have access to that machine now, but it has been freshly updated a few days ago, so it should be 0.14.8

@ejoffe
Copy link
Owner

ejoffe commented Jan 20, 2024

There was a recent bug fix for this released in 0.14.8 on 1/12/2024.
If you are running a previous version, this is a known issue.
If you are really running 0.14.8, then the issue still exists post fix.

@piefel
Copy link
Author

piefel commented Jan 22, 2024

$ git spr status
> git rev-parse --show-toplevel
enjoying git spr? add a GitHub star? [Y/n]:
panic: repository: Could not resolve to a Repository with the name 'ejoffe/spr'.


goroutine 1 [running]:
github.com/ejoffe/spr/github/githubclient.check({0x995c20, 0xc0004078a8})
	/Users/runner/work/spr/spr/github/githubclient/client.go:696 +0xf4
github.com/ejoffe/spr/github/githubclient.(*client).addStar(0xc0000b2990, {0x999390, 0xcc85c0})
	/Users/runner/work/spr/spr/github/githubclient/star.go:100 +0x5b
github.com/ejoffe/spr/github/githubclient.(*client).MaybeStar(0xc0000bb340?, {0x999390, 0xcc85c0}, 0xc0000b2738)
	/Users/runner/work/spr/spr/github/githubclient/star.go:53 +0x609
main.main.func1(0xc0000ed100?)
	/Users/runner/work/spr/spr/cmd/spr/main.go:125 +0x1a5
github.com/urfave/cli/v2.(*App).RunContext(0xc000093ba0, {0x999390?, 0xcc85c0}, {0xc0000bc000, 0x2, 0x2})
	/Users/runner/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:328 +0x722
github.com/urfave/cli/v2.(*App).Run(...)
	/Users/runner/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:247
main.main()
	/Users/runner/work/spr/spr/cmd/spr/main.go:230 +0x133b

AUTHOR: Eitan Joffe <[email protected]>
VERSION: fork of 0.14.8 : 2024-01-12T00:36:25Z : c43d4c16

@chriscz chriscz added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants