-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-param-to-use-existing-file-on-s3 #95
base: master
Are you sure you want to change the base?
Conversation
I'm not a 100% sure what you are trying to accomplish here. The blast radius is such that reviewing this for correctness is a bit hard. If I understand correctly, you wish to deploy an existing archive - where would this archive originate from? I'm not sure how relevant that kind of functionality is for this Github Action, since it would reduce the transparency of any run since what was deployed would not be immediately obvious from the triggering Git SHA. |
Update beanstalk-deploy.js
…nt-default-as-true feature/set-flag-wait-for-deployment-default-as-true
The contribution is to add a new param named "existing_file_name" to use an existing s3 file and avoid to upload a new file.
This change is to get the "build once, deploy many".
Trying to follow the "12 factor app", principle "V. Build, Release, Run".
More info: 12 factor app