Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETOS logger should send a properly formatted event #299

Open
t-persson opened this issue Oct 31, 2024 · 0 comments
Open

ETOS logger should send a properly formatted event #299

t-persson opened this issue Oct 31, 2024 · 0 comments

Comments

@t-persson
Copy link
Collaborator

Description

Today the ETOS Library RabbitMQ logger will send the log events as a JSON string with the logging fields but a proper ETOS event should be formatted as follows:

{"event": EventType, "data": Data}

Where EventType should be "message" and Data should be the logging fields, in the case of the RabbitMQ logger.
There is an assumption in the log listener that if the "event" key is not set, it should be parsed as a message. This is not good.

Additional Context

I want to create a central log listener for ETOS and this assumption will make the code more complex.

Further links

https://github.com/eiffel-community/etos-library/blob/main/src/etos_lib/logging/formatter.py#L61

https://github.com/eiffel-community/etos-suite-runner/blob/main/projects/log_listener/src/log_listener/listener.py#L63-L64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant