Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit type cherry-pick not supported #43

Open
m-linner-ericsson opened this issue Nov 26, 2019 · 0 comments
Open

Submit type cherry-pick not supported #43

m-linner-ericsson opened this issue Nov 26, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@m-linner-ericsson
Copy link
Member

m-linner-ericsson commented Nov 26, 2019

Description

When using the cherry-pick submit type with empty changes we will not behave correctly. Gerrit will always send Gerrit events even though the master branch is untouched. This happens when you create an empty change.

Motivation

Exemplification

This happens when you create and submit an empty change and have submit type cherry-pick. This is seen in the integration tests. Currently this integration is not part of the test suite (its commented out).

Benefits

The Gerrit plugin becomes more robust

Possible Drawbacks

Time-consuming to come up with a solution

@m-linner-ericsson m-linner-ericsson added the bug Something isn't working label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant