Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement curved RSU structure for the three layers of vertex barrel trackers #803

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ShujieL
Copy link
Contributor

@ShujieL ShujieL commented Nov 11, 2024

Briefly, what does this PR introduce?

created a new vertex barrel geometry file vertex_barrel_curved.xml with a new geo plugin to support smooth cylindrical surface and build-in inactive areas.
This work is a follow-up of #759 which creates flat sensors and barrel with staves.
Screenshot 2024-11-14 at 16 51 54

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • [ x ] New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • [ x] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

The # of hits on vertex barrels will reduce by a few percent due to the inactive areas.
Didn't see a significant change in tracking efficiency. Performance study on going.

…ethod has unknown offset between tube components. Will switch to part-by-part frame construction instead
…with ACTS e.g. only half of the unit is valid when making sourcelinks
@ShujieL ShujieL requested a review from wdconinc November 11, 2024 01:58
@ShujieL ShujieL self-assigned this Nov 11, 2024
@github-actions github-actions bot added topic: tracking topic: forward Positive-rapidity detectors (hadron-going side) labels Nov 11, 2024
@ShujieL ShujieL removed the topic: forward Positive-rapidity detectors (hadron-going side) label Nov 11, 2024
@github-actions github-actions bot added the topic: forward Positive-rapidity detectors (hadron-going side) label Nov 11, 2024
@ShujieL
Copy link
Contributor Author

ShujieL commented Nov 11, 2024

VertexBarrelEnvelope_length and VertexTrackingRegion_length are not used anywhere. Can we remove them from dump-parameter-table?

Also, not sure why we keep VertexCheck in the xml file.

@ShujieL
Copy link
Contributor Author

ShujieL commented Nov 11, 2024

Also, validate-material-map failed due to "Propagation reached the step count limit of 1000 (did 1000 steps)". I remember seeing this error many times in the past but they didn't interrupt the program, a material map would still be generated. Any idea on how to deal with this? @wdconinc

@wdconinc
Copy link
Contributor

Also, validate-material-map failed due to "Propagation reached the step count limit of 1000 (did 1000 steps)". I remember seeing this error many times in the past but they didn't interrupt the program, a material map would still be generated. Any idea on how to deal with this? @wdconinc

no time to look into it until next week (not even sure then)

@veprbl
Copy link
Member

veprbl commented Nov 12, 2024

Also:

MultiSegmentation ERROR Invalid sub-segmentation identifier!
VertexBarrelHandler ERROR cellID: failed to access segmentation for VolumeID: 000000000103B21F [17019423]  [MultiSegmentation: Invalid sub-segmentation identifier!]
VertexBarrelHandler ERROR ....... G4-local:   (49.820797, 1.685985, 1.892819) G4-global:   (34.036452, 36.420795, -19.331181)
VertexBarrelHandler ERROR ....... TGeo-local: (4.982080, 0.168598, 0.189282) TGeo-global: (3.403645, 3.642079, -1.933118)
VertexBarrelHandler ERROR ....... Pre-step:  AV_1555!Module2_upper_58#58!RSU_upper_3#3  SD: VertexBarrel
VertexBarrelHandler ERROR ....... Post-step: AV_11865!VertexBarrelSubAssembly_3#3!VertexBarrel_layer2_1#1  SD: 
DDSim            ERROR Simulation failed!
Geant4Kernel     FATAL +++ Exception while simulating:MultiSegmentation: Invalid sub-segmentation identifier!

configurations/craterlake.yml Outdated Show resolved Hide resolved
compact/tracking/vertex_barrel_curved.xml Outdated Show resolved Hide resolved
compact/tracking/vertex_barrel_curved.xml Outdated Show resolved Hide resolved
compact/tracking/vertex_barrel_curved.xml Outdated Show resolved Hide resolved
compact/tracking/vertex_barrel_curved.xml Outdated Show resolved Hide resolved
src/SVTBarrelTracker_geo.cpp Outdated Show resolved Hide resolved
src/SVTBarrelTracker_geo.cpp Outdated Show resolved Hide resolved
src/SVTBarrelTracker_geo.cpp Outdated Show resolved Hide resolved
src/SVTBarrelTracker_geo.cpp Outdated Show resolved Hide resolved
double m_rmin = x_mod.rmin();
double m_length = x_mod.length();
double m_width = x_mod.width();
module_length[m_nam].push_back(m_length);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the module length is necessary as a map to vector. Will there be multiple modules with the same name? Do you need the length outside of this scope?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use it to accommodate the upper and lower modules and pass to layer assembly. Is there a better way?

@ShujieL
Copy link
Contributor Author

ShujieL commented Nov 21, 2024

Also, validate-material-map failed due to "Propagation reached the step count limit of 1000 (did 1000 steps)". I remember seeing this error many times in the past but they didn't interrupt the program, a material map would still be generated. Any idea on how to deal with this? @wdconinc

no time to look into it until next week (not even sure then)

@wdconinc there is a new material mapping script to allow mapping without propagation but requires MaterialMapper from ACTS v34.
https://github.com/acts-project/acts/blob/main/Examples/Scripts/Python/material_mapping_core.py

Any plan for ACTS version upgrade?

@github-actions github-actions bot added the topic: barrel Mid-rapidity detectors label Nov 21, 2024
@veprbl veprbl requested a review from wdconinc December 3, 2024 18:05
@veprbl
Copy link
Member

veprbl commented Dec 3, 2024

@ShujieL Is this ready? Once this is merged, will you be able to deploy an updated material map?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: barrel Mid-rapidity detectors topic: forward Positive-rapidity detectors (hadron-going side) topic: tracking
Projects
Development

Successfully merging this pull request may close these issues.

3 participants