-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement curved RSU structure for the three layers of vertex barrel trackers #803
base: main
Are you sure you want to change the base?
Conversation
…ethod has unknown offset between tube components. Will switch to part-by-part frame construction instead
…e segmentation for tubes
…with ACTS e.g. only half of the unit is valid when making sourcelinks
for more information, see https://pre-commit.ci
VertexBarrelEnvelope_length and VertexTrackingRegion_length are not used anywhere. Can we remove them from dump-parameter-table? Also, not sure why we keep VertexCheck in the xml file. |
Also, validate-material-map failed due to "Propagation reached the step count limit of 1000 (did 1000 steps)". I remember seeing this error many times in the past but they didn't interrupt the program, a material map would still be generated. Any idea on how to deal with this? @wdconinc |
no time to look into it until next week (not even sure then) |
Also:
|
src/SVTBarrelTracker_geo.cpp
Outdated
double m_rmin = x_mod.rmin(); | ||
double m_length = x_mod.length(); | ||
double m_width = x_mod.width(); | ||
module_length[m_nam].push_back(m_length); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why the module length is necessary as a map to vector. Will there be multiple modules with the same name? Do you need the length outside of this scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use it to accommodate the upper and lower modules and pass to layer assembly. Is there a better way?
Co-authored-by: Wouter Deconinck <[email protected]>
@wdconinc there is a new material mapping script to allow mapping without propagation but requires MaterialMapper from ACTS v34. Any plan for ACTS version upgrade? |
for more information, see https://pre-commit.ci
@ShujieL Is this ready? Once this is merged, will you be able to deploy an updated material map? |
Briefly, what does this PR introduce?
created a new vertex barrel geometry file vertex_barrel_curved.xml with a new geo plugin to support smooth cylindrical surface and build-in inactive areas.
This work is a follow-up of #759 which creates flat sensors and barrel with staves.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?
The # of hits on vertex barrels will reduce by a few percent due to the inactive areas.
Didn't see a significant change in tracking efficiency. Performance study on going.