fix: rename LFHCAL to HcalEndcapP in outward interface (geometry, collections) #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: forward
wdconinc
force-pushed
the
LFHCAL-HcalEndcapP
branch
from
6542a82 to
4b5f7e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
For consistency, the outward interface of our simulation and reconstruction software aims to adhere to a standardized naming scheme. This is unrelated to the names of DSCs or how people refer to their detectors, and is outlined in https://docs.google.com/document/d/1TfEDVTTeRQ0fjyPqdLd0d8AEs6Zsr57qNezEDnDw_5g/.
This PR renames the outwardly accessible references from LFHCAL to HcalEndcapP. Internal naming is not changed (e.g. names of source files). Backwards compatibility is maintained by writing both
LFHCALHitsandHcalEndcapPHits.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.