-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D rich envelope 07052023 #448
base: main
Are you sure you want to change the base?
Conversation
Hi @c-dilks the parameters are now the following:
Almost all definitions are now in the |
The only concern I have is the
Can spherical patch rmax still be |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
The z-positioning and length are difficult to change, since several other detectors depend on these parameters. I will push a commit that tries to do a bit better, but we're gonna need some help from other subsystem experts on this one... |
@chchatte92 What is the update of this PR? Should it be included in the February release? |
Briefly, what does this PR introduce?
This PR takes into account the newly updated description of the dRICH envelope, following the presentation of Alessandro (https://indico.bnl.gov/event/19746/).
The optics tuning is underway.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Chris and Marco has been notified.
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No