Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector ID constants use ECal*, HCal* etc, but all else uses Ecal*, Hcal* #557

Open
wdconinc opened this issue Oct 11, 2023 · 1 comment

Comments

@wdconinc
Copy link
Contributor

Environment: (where does this bug occur, have you tried other environments)

  • Which branch (main for latest released): main
  • Which revision (HEAD for the most recent): HEAD
  • Any specific OS or system where the issue occurs? no
  • Any special versions of ROOT or Geant4? no

Steps to reproduce: (give a step by step account of how to trigger the bug)

The difference in capitalization makes this error-prone, e.g. eic/EICrecon#1070.

Expected Result: (what do you expect when you execute the steps above)

We should use a consistent capitalization.

Actual Result: (what do you get when you execute the steps above)

We aren't using a consistent capitalization.

Additional Context

Probably this can all be included in a major renaming overhaul...

@wdconinc
Copy link
Contributor Author

@veprbl fyi

@veprbl veprbl self-assigned this Feb 9, 2024
@veprbl veprbl removed their assignment Feb 10, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2024
First step for #557 in which we provide Ecal* and Hcal* names.

Next step would be to use those names in EICrecon.

Final step is to remove the deprecated aliases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants