Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: build with C++20 standard #116

Closed
wants to merge 1 commit into from
Closed

test: build with C++20 standard #116

wants to merge 1 commit into from

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Nov 27, 2023

Briefly, what does this PR introduce?

test for #115

@c-dilks
Copy link
Member Author

c-dilks commented Nov 27, 2023

same issue....

@c-dilks c-dilks closed this Nov 27, 2023
@wdconinc
Copy link
Contributor

It seems you build and install EICrecon into prefix/ in build_2, then try to build EICrecon again in build_3.

#pragma once doesn't like that you have -I the prefix, and -I the same directory in the second EICrecon source tree. That's (arguably) the main drawback of #pragma once, but in this case it's probably just helping to surface an issue that you want to address: you probably don't intend to build EICrecon twice.

@c-dilks
Copy link
Member Author

c-dilks commented Nov 28, 2023

Ah, good catch. I wonder why this hasn't surfaced before. We likely no longer need to test re-building parts of richgeo to a separate shared library.

@c-dilks c-dilks deleted the cpp-20 branch November 28, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants