fix: move static ParticleMap into header as inline for downstream use #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmans1
force-pushed
the
particle-svc-header-only
branch
from
d25af63 to
5b62cce
Compare
Capybara summary for PR 1538 |
|
Capybara claims no differences. This shouldn't introduce any differences at all, so I'm surprised it's showing differences for you. |
|
@rahmans1 Can you explain why you see differences here? Is your 'standard' eicrecon the one just before this PR/commit, or could it include other merges? Based on capybara, I don't see any diffs. |
wdconinc
force-pushed
the
particle-svc-header-only
branch
from
5b62cce to
0899a40
Compare
wdconinc
requested review from
a team and
rahmans1
and removed request for
a team
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Downstream plugins that use the ParticleSvc as an interface just include the header and are supposed to link against the library to get the static member. Having to load a shared library for just a static list is a bit annoying for a servicde interface definition.
This PR moves the static default list into an inline static definition (not a shared_ptr), and everything now lives in the header.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.