-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rework podio options to allow specifying list, includes, and excludes #1323
base: main
Are you sure you want to change the base?
fix: rework podio options to allow specifying list, includes, and excludes #1323
Conversation
for more information, see https://pre-commit.ci
Capybara summary for PR 1323 |
14500c9
to
5b24b75
Compare
I've been looking at this for a while now. I guess I have two concerns regarding this:
|
Both reasonable concerns.
|
I haven't had a need to copy the input collections. It would be easy enough to analyze files in parallel because the events match.
The pattern sounds like what I had in mind, we could do even slower. A boolean |
Merge queue setting changed
…meter (#1466) This is a follow up on a resolution from #1323 ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? No
Briefly, what does this PR introduce?
This PR somewhat redefines the behavior of the option
-Ppodio:output_include_collections
in order to fix #300. There are now three similar options:-Ppodio:output_collections
specifies which output collections to write,-Ppodio:output_include_collections
specifies which output collections to include in addition to the default set,-Ppodio:output_exclude_collections
specifies which output collections to exclude from the default set.The behavior is technically backwards compatible. Where previously
-Ppodio:output_include_collections
resulted in only those collections being added to the output, now those collections will be added to the default set.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No. More collections will be written when using
-Ppodio:output_include_collections
.