Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License for this package? #14

Closed
wking opened this issue Jan 9, 2018 · 7 comments
Closed

License for this package? #14

wking opened this issue Jan 9, 2018 · 7 comments

Comments

@wking
Copy link
Contributor

wking commented Jan 9, 2018

I'd like to transition from / to AND or OR in our own Cargo.toml (compare rust-lang/cargo#4920). My guess is that the intended license is MIT OR Apache-2.0 (i.e. “consumers may choose either the MIT terms or the Apache-2.0 terms, at their option”) and not MIT AND Apache-2.0 (i.e. “consumers must satisfy both the MIT terms and the Apache-2.0 terms”). MIT AND Apache-2.0 would seem like a pretty strange choice…

@withoutboats, can you weigh in? What license expression did you intend?

@breard-r, @ltratt, and @nodakai, you also have commits in master. Did you have license intentions for those contributions? Or are you comfortable with whichever of the above @withoutboats intended?
@withoutboats
Copy link
Collaborator

It was intended to be licensed however crates.io is licensed (since that was the original use case). AFAIK that is OR.

@wking
Copy link
Contributor Author

wking commented Jan 9, 2018

It was intended to be licensed however crates.io is licensed (since that was the original use case). AFAIK that is OR.

OR is my guess too, but I've filed rust-lang/crates.io#1225 to get some clarity on it.

@breard-r
Copy link
Contributor

breard-r commented Jan 9, 2018

According to the SPDX Specification, appendix IV, the correct term in this case is OR:

Often a single license can be used to represent the licensing terms of a source code or binary file, but there are situations where a single license identifier is not sufficient. A common example is when software is offered under a choice of one or more licenses (e.g., GPL-2.0 OR BSD-3-Clause). Another example is when a set of licenses is needed to represent a binary program constructed by compiling and linking two (or more) different source files each governed by different licenses (e.g., LGPL-2.1 AND BSD-3-Clause).

@wking
Copy link
Contributor Author

wking commented Jan 9, 2018

According to the SPDX Specification, appendix IV, the correct term in this case is OR…

I agree that that matches rust-lang/rust's usage. It's less clear to me that all the contributors here intended the OR semantics for their contributions. Since there aren't many contributors here (and they're all still alive, or at least have pushed recent commits to GitHub ;), it seems safest to just ask them all about their intentions. So far, we have @withoutboats following crates.io (where at least one contributor intended OR) and you intending OR. That leaves @ltratt and @nodakai as the only contributors who haven't chimed in with their intentions.

@ltratt
Copy link
Contributor

ltratt commented Jan 9, 2018

I'm happy with the proposed change.

@wking
Copy link
Contributor Author

wking commented Jan 10, 2018

Crates.io is now officially OR with rust-lang/crates.io#1226. So everything is squared away for OR except a coment from @nodakai about his intentions for #8. And that's small enough that I'm willing to claim it uncopyrightable and move ahead with OR even without feedback.

wking added a commit to wking/license-exprs that referenced this issue Jan 11, 2018
@wking
Cargo.toml: Replace '/' with 'OR' in 'license'
c8f2219 
Catch up with the recommendations from rust-lang/cargo@7dee65fe
(src/doc/manifest: Pin 'license' to SPDX 2.1 expressions and the 2.4
list, 2018-01-04, rust-lang/cargo#4898), which deprecated '/' in favor
of vanilla SPDX license expressions.

I've gone with the disjunctive OR, and most contributors have signed
off on that change:

* Without Boats wanted to match the crates.io licensing [1], and they
  meant OR [2].
* Rodolphe Breard [3] and Laurence Tratt [4] intended OR.

We haven't heard back from Kai NODA, but ed9fe0b (README.md: update
the reference to SPDX, 2017-07-14, ehuss#8) is probably too small to be
copyrightable.

[1]: ehuss#14 (comment)
[2]: rust-lang/crates.io#1226
[3]: ehuss#14 (comment)
[4]: ehuss#14 (comment)
@wking wking mentioned this issue Jan 11, 2018
Merged
@nodakai
Copy link
Contributor

nodakai commented Jan 11, 2018

@wking Sorry I'm on a trip to Vietnam countryside

I'd be happy to see the change. Please accept this as my agreement that my (tiny) PRs follow the proposed re-licensing

wking added a commit to wking/license-exprs that referenced this issue Jan 11, 2018
@wking
Cargo.toml: Replace '/' with 'OR' in 'license'
37a39a6 
Catch up with the recommendations from rust-lang/cargo@7dee65fe
(src/doc/manifest: Pin 'license' to SPDX 2.1 expressions and the 2.4
list, 2018-01-04, rust-lang/cargo#4898), which deprecated '/' in favor
of vanilla SPDX license expressions.

I've gone with the disjunctive OR, and most contributors have signed
off on that change:

* Without Boats wanted to match the crates.io licensing [1], and they
  meant OR [2].
* Rodolphe Breard [3], Laurence Tratt [4], and Kai NODA [5] intended
  OR.

[1]: ehuss#14 (comment)
[2]: rust-lang/crates.io#1226
[3]: ehuss#14 (comment)
[4]: ehuss#14 (comment)
[5]: ehuss#14 (comment)
@wking wking closed this as completed in #16 Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ltratt @nodakai @breard-r @wking @withoutboats