Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sonar workflow_run action #608

Merged
merged 4 commits into from
May 28, 2024

Conversation

alexlehn
Copy link
Contributor

@alexlehn alexlehn commented May 27, 2024

Changes

Use the extracted sonar analyses from this workflow_run -> https://github.com/ehrbase/openEHR_SDK/blob/develop/.github/workflows/report-sonar-results.yml.

The build logic is now:

#1 Build & Test

  • run unit tests with coverage
  • run integration tests with coverage and combine results
  • upload overall coverage

#2 Sonar Report

  • download overall coverage
  • run sonar report with workflow_run.pullrequest target

This allow to use the sonar report also for PR from forked repositories.

other changes:

  • adjusted build and test name to be aligned with ehrbase
  • adjusted codeql & checkstyle wotkflows definitions and name to be aligned with ehrbase

If this change is ok and merge I'll check it with a dependabot PR. In case this succeeds I will adopt the ehrbase repo sonar analyses in the same way.

Pre-Merge checklist

  • New code is tested
  • Present and new tests pass
  • Documentation is updated
  • The build is working without errors
  • No new Sonar issues introduced
  • Changelog is updated
  • Code has been reviewed

@alexlehn alexlehn force-pushed the feature/fix-github-action-sonar-access-part2 branch 3 times, most recently from 2596a13 to 02910ad Compare May 27, 2024 10:21
@alexlehn alexlehn force-pushed the feature/fix-github-action-sonar-access-part2 branch 4 times, most recently from 9436072 to 1c18b6f Compare May 27, 2024 13:23
@alexlehn alexlehn force-pushed the feature/fix-github-action-sonar-access-part2 branch from 2ee8db2 to 1e8e1b5 Compare May 27, 2024 13:54
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alexlehn alexlehn marked this pull request as ready for review May 27, 2024 14:20
@alexlehn alexlehn requested a review from vidi42 May 28, 2024 06:13
@alexlehn alexlehn merged commit 0a3146f into develop May 28, 2024
5 checks passed
@alexlehn alexlehn deleted the feature/fix-github-action-sonar-access-part2 branch May 28, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants