Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ARM support #34

Open
ehough opened this issue Jan 21, 2020 · 3 comments
Open

feature: ARM support #34

ehough opened this issue Jan 21, 2020 · 3 comments

Comments

@ehough
Copy link
Owner

ehough commented Jan 21, 2020

Currently the image is only built for x86-64. We should build an ARM-based image that can run on, for example, Raspberry Pi.

@testautomation
Copy link

subscribed :)

@flavioschuindt
Copy link

Hey @ehough, I've implemented this. Just tested and it's working super fine on my raspberry: https://hub.docker.com/repository/docker/fschuindt/docker-nfs-server

Note that it's entirely based on yours and I was thinking initially to actually fork your repo and submit a PR. However, since last year, Docker for Desktop offers a nice feature called buildx. This means that from a single Dockerfile, I can from my amd64 computer, cross build it to different archs. You can read more about it here. With this in mind, I just cloned your repo and following the link, I could successfully generate a new image and pushed to my own repo with no changes in the original Dockerfile in this repo.

Let me know how you wanna handle this. Ideally, you could follow the link and add instructions on the README so people can cross build it. After this, you can start rebuilding this to your own repo on docker hub and then everyone will have multi arch support. I can help with the README, just let me know the best approach as you control the repo here.

@pramitbiswas
Copy link

@flavioschuindt your link is not accessible without login to the docker hub. Can you please check that? You can also add a PR for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants