You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
currently, we define regex to extract content from a function in two places:
extractTypeDefForSelectExpressions (query)
extractTypeDefForInputVariables (query)
so every time we modify what a valid function looks like, we have to modify in both places.
if this occurs regularly or we add a third place where we need this knowledge, we absolutely should generalize that information out into a "getFunctionDefinitionFromSql" utility - which can expose the array of arguments and the function name, satisfying all of our use cases
The text was updated successfully, but these errors were encountered:
currently, we define regex to extract content from a function in two places:
so every time we modify what a valid function looks like, we have to modify in both places.
if this occurs regularly or we add a third place where we need this knowledge, we absolutely should generalize that information out into a "getFunctionDefinitionFromSql" utility - which can expose the array of arguments and the function name, satisfying all of our use cases
The text was updated successfully, but these errors were encountered: