Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usecase extensions should be transitive #17

Open
uladkasach opened this issue Dec 27, 2022 · 0 comments
Open

usecase extensions should be transitive #17

uladkasach opened this issue Dec 27, 2022 · 0 comments

Comments

@uladkasach
Copy link
Member

right now

# define the different types of combinations of the best practices that we support
use-cases:
  typescript-project:
    practices:
      - cicd-integrate
      - conventional-commits
      - directory-structure-src
      - domain
      - errors
      - format
      - git
      - linting
      - node
      - nonpublished-modules
      - package-json-order
      - prettier
      - testing
      - typescript
      - uuid
  npm-package:
    extends:
      - typescript-project
    practices:
      - cicd-deploy-package
  lambda-service:
    extends:
      - typescript-project
    practices:
      - cicd-deploy-service
      - config
      - dates-and-times
      - environments
      - lambda-clients
      - lambda-handlers
      - logging
      - runtime-type-checking
      - serverless
      - terraform
  lambda-service-with-rds:
    extends:
      - lambda-service
    practices:
      - persist-with-rds

results in lambda-service-with-rds not having any of the practices listed in typescript-project, even though it extends lambda-service which extends typescript-project

we would expect that typescript-project extension is transitively applied from lambda-service extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant