Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code rollback issues #3221

Open
toplifangkai opened this issue Apr 7, 2024 · 0 comments
Open

Code rollback issues #3221

toplifangkai opened this issue Apr 7, 2024 · 0 comments

Comments

@toplifangkai
Copy link

toplifangkai commented Apr 7, 2024

BatchingLocalHeapWriteBehindQueue:
public void run() {
List<BatchOperation<K, V>> batches = createMonomorphicBatches(operations());
// execute the batch operations
for (BatchOperation<K, V> batch : batches) {
try {
try {
batch.performOperation(cacheLoaderWriter);
} finally {
try {
for (K key : batch.getKeys()) {
latest.remove(key);
}
} finally {
LOGGER.debug("Cancelling batch expiry task");
expireTask.cancel(false);
}
}
}
catch (Exception ex) {
for (K key : batch.getKeys()) {
keyCleanUpMethod.accept(key);
}
LOGGER.warn("Exception while bulk processing in write behind queue", ex);
}
}
}

new: in master and since tag v3.10.9-internal9
for (K key : batch.getKeys()) { latest.remove(key); }
before:
for (SingleOperation<K, V> op : operations()) { latest.remove(op.getKey(), op); }

I would like to know why you changed it back. Are there any special considerations? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant