Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OrdComparator and OrdStoredKey from root #5

Closed
eggyal opened this issue Jan 2, 2023 · 1 comment · Fixed by #14
Closed

Move OrdComparator and OrdStoredKey from root #5

eggyal opened this issue Jan 2, 2023 · 1 comment · Fixed by #14
Labels
question Further information is requested

Comments

@eggyal
Copy link
Owner

eggyal commented Jan 2, 2023

Perhaps into a default submodule?

Maybe even put their functionality behind a feature flag (indeed, if disabled, we could instead provide a blanket impl<C: Comparator> LookupKey<C> for C::Key which might actually be more useful; with specialization we should be able to provide both blanket implementations).
@eggyal eggyal added the question Further information is requested label Jan 2, 2023
@eggyal eggyal mentioned this issue Jan 15, 2023
Merged
@eggyal
Copy link
Owner Author

eggyal commented Jan 15, 2023

Let's not place behind a feature flag until there's better test coverage for non-default comparators (#4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move OrdComparator, OrdStoredKey to default mod eggyal/copse
1 participant
@eggyal