Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login page hindered by resolution restrictions. #253

Open
sofusalbertsen opened this issue Mar 10, 2021 · 4 comments
Open

Login page hindered by resolution restrictions. #253

sofusalbertsen opened this issue Mar 10, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@sofusalbertsen
Copy link
Contributor

None-game pages should not have restrictions on the heights and widths. It's not intuitive for the user.

https://pipelinegame.eficode.com/login

Screenshot from 2021-03-10 13-34-07

@rams23
Copy link
Contributor

rams23 commented Mar 11, 2021

Hi @sofusalbertsen, do you see it only on small window size? or it's a problem like the one presented by Szilard on slack? According to the conversation under #216, we add the dialog on all the pages. We can remove it on some of them but then the users will see something like this ( iphone 11 viewport)
image

@sofusalbertsen
Copy link
Contributor Author

How dynamic is the boundaries?
Can we eg. set a X600 pixels bound on signup page instead?
It just feels like a smack in the face to people that they cannot even sign up on a phone, and most phones have 600+ pixels horizontal.

@rams23
Copy link
Contributor

rams23 commented Mar 11, 2021

Do you mean letting the user see the signup page on mobile but then, after it, show the dialog "Screen not enough" dialog? After that, the main pages will not be available on mobile. It's not an absolute device resolution problem but the viewport size, according to device resolution + devicePixelRatio that result in actual "virtual pixel". Generally, mobile devices have high pixel density so devicePixelRatio is higher than 2/2.5 resulting in an actual resolution of 360x623 for example for a P20 pro (1080*2244)

@sofusalbertsen
Copy link
Contributor Author

My thought was that it was only when you joined a game that the restrictions were on.
I can se the responsiveness of the signup and login are not catered towards small screens (as agreed with the game in it's entirety).
600 px in viewport would make that most mobile phones would pass on home/login/signup screen, which would be preferable.
But the game itself is 100% ok with having 800px limit

@rams23 rams23 added the enhancement New feature or request label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants