Ignore comments and add error checking. #542
Conversation
Require default constants in 13'hxxxx format. Require default constants to be 13 binary bits maximum. Standardize file names to lower case hex digits. NOTE: Invalid values are merely ignored. No error code is returned.
There was a problem hiding this comment.
I think this should handle most of the ways that a user would mess with the user defaults file. Ideally, it needs a proper verilog parser to catch all the possible ways that a user could screw up this script. I wonder if it needs a more forceful exit on error in a way that would halt the build process instead of just printing an error message. Or does the makefile target catch the error?
Good point. One solution would be to fail on missing definitions (bad definitions would be missing) when doing the replacement in the mag/verilog. Can we make that a new issue and go ahead with this update? |
Require default constants in 13'hxxxx format.
Require default constants to be 13 binary bits maximum.
Standardize file names to lower case hex digits.
NOTE: Invalid values are merely ignored. No error code is returned.
Fixes #539 and #540