feat: basic structure of logic #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add whitespace in Ship.cs(109, 17), Team.cs(28, 19)
- split BulletFactory - split Laser, Plasma, Shell, Missile, Arc - remove the braces of namespace - refactor AP
- split all the modules from namespace Interface to GameClass - split ModuleFactory
|
没有 Main 函数，以及没有实现接口 |
shangfengh
reviewed
Oct 26, 2023
logic/GameClass/GameObj/ObjOfShip.cs
Outdated
| { | ||
| get | ||
| { | ||
| lock (objOfShipReaderWriterLock) |
There was a problem hiding this comment.
这个是来自于去年的错误，要么采用lock(object)的方式，要么采用ReaderWriterLockSlim的方法EnterReadLock()及ExitReadLock()，写入类似
|
建议可以上传初版规则 |
- revise ObjOfShipReaderWriterLock to ObjOfShipLock - revise ActionLock to actionLock in Ship.cs
- add GameObj of Areas - add AreaFactory - adjust the switch-expr of other factories
Ships can move now (probably)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of this pull request:
No additional description.