chore: remove cwd from datadog-ci sourcemaps upload #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug logs confirmed the sourcemaps do in fact exist within
app_dist. Given this, I believe the culprit may be due to passingcwd=self.app_namewhen running thedatadog-ciCLI command.The default current working directory within
FrontendDeployeris as follows, and contains the below directories:b'Deploy frontend: [DEBUG] Current working directory: /godata/pipelines/stage-frontend-app-learner-portal-enterprise'b"Deploy frontend: [DEBUG] current working directory contents: ['edx-internal', 'tubular', 'frontend-app-learner-portal-enterprise', 'target']"The default current working directory contains the
targetdirectory (i.e., the resulting build output fromFrontendBuilder). However, running thedatadog-cicommand within thefrontend-app-learner-portal-enterprisedirectory (due to thecwd=self.app_name) means thetargetdirectory is not reachable since it's not a descendent ofcwd=self.app_name.The output of the
app_distis what we'd expect, containing the built JS source and sourcemap files:b"Deploy frontend: [DEBUG] app_dist contents: ['8030.9e695bd04644a14a18c5.js.map', '27dd23381721eb3498bae7a80ad4facd.jpg', '5885.55e2fc782bce49685e85.js.LICENSE.txt', '8358.b325417e68a39e55915b.js.map', '3638.74d07288636b4363e5ba.js.map', '9629.0be115a201f88cd6b458.css', '6592.0550914088cb483fb9c8.js.map', '1981.52ef16ad0794137db7d1.js.map', 'app-84781932.a09ea94d8b4f3b86d496.js.map', '8396.b6f9bd8bfdd7e3057a5d.js.map', ...]