Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass --project-path option when uploading JS sourcemaps to Datadog #6

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Jun 12, 2024

Starting upload with concurrency 20. 
Will look for sourcemaps in target/dist
Will match JS files for errors on files starting with /
version: b533813f29e4221ab3b48c51b55c5f9710776118 service: edx-frontend-app-learner-portal-enterprise project path: 

Command summary:
⚠️ No sourcemaps detected. Did you specify the correct directory?
b'Deploy frontend: Uploading source maps to Datadog for app frontend-app-learner-portal-enterprise.'

When attempting an MFE deployment, datadog-ci is failing to detect JS source maps in the dist directory. This PR attempts to resolve by providing the --project-path command arg to datadog-ci per the Datadog documentation:

image image

When looking at the sourcemaps generated by @openedx/frontend-build, the file paths do seem to reference a prefix of the app name. Example:

{
  "sources": [
    "webpack://frontend-app-learner-portal-enterprise/./src/components/integration-warning-modal/ModalBody.jsx"
  ],
}

This PR attempts to see if sourcemaps can be detected by providing the `f'--project-path="{self.app_name}/"', to the Datadog CLI command.

@adamstankiewicz adamstankiewicz changed the title fix: remove cwd option when uploading JS sourcemaps to Datadog fix: pass --project-path option when uploading JS sourcemaps to Datadog Jun 12, 2024
@adamstankiewicz adamstankiewicz merged commit ae4fd29 into master Jun 12, 2024
4 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/datadog-sourcemaps-pt4 branch June 12, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants