Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: always return tuple in _upload_js_sourcemaps_config #10

Merged
merged 1 commit into from
Jun 12, 2024
Merged

chore: always return tuple in _upload_js_sourcemaps_config #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tubular/scripts/frontend_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,19 +250,19 @@ def _upload_js_sourcemaps_config(self):
# before executing the Datadog CLI. The Datadog documentation suggests using a dedicated Datadog API key:
# https://docs.datadoghq.com/real_user_monitoring/guide/upload-javascript-source-maps/
self.LOG('Could not find DATADOG_API_KEY environment variable while uploading source maps.')
return
return None, None

service = app_config.get('DATADOG_SERVICE')
if not service:
self.LOG('Could not find DATADOG_SERVICE for app {} while uploading source maps.'.format(self.app_name))
return
return None, None

# Determine version for deployment, prioritizing app-specific version override, if any, before
# default APP_VERSION commit SHA version.
version = app_config.get('DATADOG_VERSION') or app_config.get('APP_VERSION')
if not version:
self.LOG('Could not find version for app {} while uploading source maps.'.format(self.app_name))
return
return service, None

# Successfully determined service and version for the app deployment
return service, version
Expand Down
Loading