Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update DD config on insights #38

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Jun 12, 2024

Following the New Relic to Datadog Service APM migration guide, this flags should enable Insights for logging APMs on Datadog for production.

@rijuma rijuma changed the title chore: Updated DD config on insights chore: Update DD config on insights Jun 12, 2024
@rijuma rijuma marked this pull request as ready for review June 12, 2024 12:33
@rijuma rijuma requested review from robrap and timmc-edx June 12, 2024 13:20
Copy link
Member

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although please use feat instead of chore in the PR and commit title for feature changes.

https://github.com/openedx/open-edx-proposals/blob/master/oeps/best-practices/oep-0051-bp-conventional-commits.rst#type

@rijuma rijuma force-pushed the rijuma/enable-dd-insights-analytics branch from c3b1f10 to 2210d65 Compare June 12, 2024 15:31
@rijuma rijuma changed the title chore: Update DD config on insights feat: Update DD config on insights Jun 12, 2024
@rijuma
Copy link
Member Author

rijuma commented Jun 12, 2024

Updated both commit and PR prefixes to feat:

@rijuma rijuma merged commit e91e293 into master Jun 12, 2024
4 checks passed
@rijuma rijuma deleted the rijuma/enable-dd-insights-analytics branch June 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants