Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send enrollment/fulfillment failure email on unsupported course mode #302

Merged
merged 6 commits into from
Dec 4, 2024
Merged

feat: send enrollment/fulfillment failure email on unsupported course mode #302

merged 6 commits into from
Dec 4, 2024

Conversation

syedsajjadkazmii
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii commented Nov 27, 2024 •
edited
Loading

This PR adds the functionality to send Fulfillment failure email if the Fulfillment celery fails due to unsupported course mode.

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/SONIC-795 branch 11 times, most recently from e4248b9 to c898efa Compare November 28, 2024 09:53
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/SONIC-795 branch 16 times, most recently from b7dc79a to 19e195d Compare November 28, 2024 13:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  commerce_coordinator/apps/commercetools
  serializers.py
  utils.py
  commerce_coordinator/apps/commercetools/tests
  test_utils.py
  commerce_coordinator/apps/lms
  tasks.py
  commerce_coordinator/apps/lms/tests
  test_tasks.py
Project Total  

This report was generated by python-coverage-comment-action

aht007
aht007 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some improvement comments. 🚀

commerce_coordinator/apps/lms/tasks.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/lms/tasks.py Outdated Show resolved Hide resolved
commerce_coordinator/settings/base.py Outdated Show resolved Hide resolved
NawfalAhmed
NawfalAhmed approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@NawfalAhmed NawfalAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@syedsajjadkazmii syedsajjadkazmii removed the request for review from mubbsharanwar December 4, 2024 05:19
shafqatfarhan
shafqatfarhan reviewed Dec 4, 2024
View reviewed changes
commerce_coordinator/settings/base.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/lms/tasks.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/lms/tasks.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/lms/tasks.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/commercetools/utils.py Outdated Show resolved Hide resolved
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/SONIC-795 branch 3 times, most recently from 01c6c33 to e8e57b2 Compare December 4, 2024 09:46
shafqatfarhan
shafqatfarhan approved these changes Dec 4, 2024
View reviewed changes
commerce_coordinator/apps/lms/tasks.py Outdated Show resolved Hide resolved
@syedsajjadkazmii syedsajjadkazmii merged commit 0522131 into main Dec 4, 2024
8 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/SONIC-795 branch December 4, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mubbsharanwar mubbsharanwar mubbsharanwar left review comments

@NawfalAhmed NawfalAhmed NawfalAhmed approved these changes

@aht007 aht007 aht007 approved these changes

@shafqatfarhan shafqatfarhan shafqatfarhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@syedsajjadkazmii @shafqatfarhan @aht007 @mubbsharanwar @NawfalAhmed @NoyanAziz