Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front page slideshow is missing banner images, in RTL mode. #50

Open
nadavkav opened this issue Mar 23, 2014 · 5 comments
Open

Front page slideshow is missing banner images, in RTL mode. #50

nadavkav opened this issue Mar 23, 2014 · 5 comments

Comments

@nadavkav
Copy link

I set 3 slideshow banner images (+ texts and colors) on the Front page slideshow (jquery widget). When in LTR mode (English) all looks good.
When in RTL mode (Hebrew) The first image shows, But the reset of the images do not.

I get an error (Chrome dev tools console)
Failed to load resource: the server responded with a status of 404 (not found) http://localhost/moodle-org/master/theme/image.php/elegance/theme/1395578699/

Cleared the cache several times. Also used Firefox. I get the same error.

Any ideas?

@gjb2048
Copy link
Contributor

gjb2048 commented Mar 23, 2014

RTL is not yet fully supported on BS3, I believe they are working on it.

Sent from my iPod in deep space...

On 23 Mar 2014, at 12:56, Nadav Kavalerchik [email protected] wrote:

I set 3 slideshow banner images (+ texts and colors) on the Front page slideshow (jquery widget). When in LTR mode (English) all looks good.
When in RTL mode (Hebrew) The first image shows, But the reset of the images do not.

I get an error (Chrome dev tools console)
Failed to load resource: the server responded with a status of 404 (not found) http://localhost/moodle-org/master/theme/image.php/elegance/theme/1395578699/

Cleared the cache several times. Also used Firefox. I get the same error.

Any ideas?


Reply to this email directly or view it on GitHub.

@nadavkav
Copy link
Author

I think it has somthing to do with the generated cache images Moodle is
making in RTL mode.
Not sure if it is connected to BS3.

On 23 March 2014 14:59, Gareth J Barnard [email protected] wrote:

RTL is not yet fully supported on BS3, I believe they are working on it.

Sent from my iPod in deep space...

On 23 Mar 2014, at 12:56, Nadav Kavalerchik [email protected]
wrote:

I set 3 slideshow banner images (+ texts and colors) on the Front page
slideshow (jquery widget). When in LTR mode (English) all looks good.
When in RTL mode (Hebrew) The first image shows, But the reset of the
images do not.

I get an error (Chrome dev tools console)
Failed to load resource: the server responded with a status of 404 (not
found)
http://localhost/moodle-org/master/theme/image.php/elegance/theme/1395578699/

Cleared the cache several times. Also used Firefox. I get the same
error.

Any ideas?

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-38381679
.

@nadavkav
Copy link
Author

I did some digging. You are right. it is lack of RTL support in the slideshow plugin.

@nadavkav
Copy link
Author

Found a quick fix (workaround)
.dir-rtl .banner {direction: ltr;}
Please see if you can added it to moodle-rtl.css

@bprad
Copy link

bprad commented Sep 10, 2014

hi nadavkav
very useful advice.i use your css suggestion in custom css field in general setting of elegance and it's work fine

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants