Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(palma): add support to css variables and cdn compatibility #3

Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat(palma): add support to css variables and cdn compatibility #3

merged 3 commits into from
Jan 11, 2024

Conversation

dcoa
Copy link

@dcoa dcoa commented Nov 28, 2023 •
edited
Loading

@dcoa dcoa changed the base branch from ednx-release/palma.master to master November 28, 2023 07:41
@dcoa dcoa changed the base branch from master to ednx-release/palma.master November 28, 2023 07:42
@dcoa dcoa changed the title feat: add support to css variables and cdn compatibility feat(lpalma): add support to css variables and cdn compatibility Dec 5, 2023
@dcoa dcoa changed the title feat(lpalma): add support to css variables and cdn compatibility feat(palma): add support to css variables and cdn compatibility Dec 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (ednx-release/palma.master@66bae17). Click here to learn what that means.

Additional details and impacted files 
@@                      Coverage Diff                      @@
##             ednx-release/palma.master        #3   +/-   ##
=============================================================
  Coverage                             ?   100.00%           
=============================================================
  Files                                ?       122           
  Lines                                ?      1268           
  Branches                             ?       249           
=============================================================
  Hits                                 ?      1268           
  Misses                               ?         0           
  Partials                             ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcoa dcoa marked this pull request as ready for review December 5, 2023 12:21
bra-i-am
bra-i-am approved these changes Dec 12, 2023
View reviewed changes
Copy link

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!

Without the MFE_CONFIG_OVERRIDES

image

With the MFE_CONFIG_OVERRIDES

image

@dcoa dcoa force-pushed the dcoa/css-cdn-support-palm branch from 3e3a051 to e19deda Compare December 20, 2023 06:15
@dcoa dcoa merged commit 40c5049 into ednx-release/palma.master Jan 11, 2024
3 checks passed
@johanseto johanseto mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bra-i-am bra-i-am bra-i-am approved these changes

@MaferMazu MaferMazu MaferMazu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcoa @codecov-commenter @MaferMazu @bra-i-am