Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][fork] Update fork with lastest changes in upstream #2

Merged
merged 31 commits into from
Nov 15, 2023

Conversation

bra-i-am
Copy link

@bra-i-am bra-i-am commented Nov 9, 2023

This PR updates the fork of this MFE with the lastest changes in upstream

https://edunext.atlassian.net/browse/DS-722

Syed-Ali-Abbas-Zaidi and others added 26 commits March 21, 2023 14:26
frontend-platform supports runtime configuration since 2.5.0 (see the PR
that introduced it[1], but it requires MFE cooperation.  This implements
just that: by avoiding making configuration values constant, it should
now be possible to change them after initialization.

Only a single change related to the `LMS_BASE_URL` setting was required.

[1] openedx/frontend-platform#335
* refactor: migrate off paragon modal deprecated component

* refactor: migrate off paragon modal deprecated component

* refactor: resource the close button string

* refactor: remove extra file

* refactor: add message in messages  file
The default behavior of the TinyMCE editor is to rewrite links that share the same
domain as the component to be relative to that path. Relative URLs will never work in
email contents, so they _always_ need to be absolute URLs. This adds the configuration
settings for `relative_urls` and `remove_script_host` in TinyMCE to always be false,
enabling it to always use absolute URLs. See
[here](https://www.tiny.cloud/docs/configure/url-handling/) for reference.
Adds a couple of missing features for proper runtime configuration:

1. Favicon runtime configuration support via react-helmet

2. Placeholder values for APP_ID and MFE_CONFIG_API_URL in the sample
   .env files
* feat: update react & react-dom to v17
* build: update paragon version
* refactor: updated edx packages
---------
Co-authored-by: mashal-m <[email protected]>
* docs: readme updated with frontend-template-app readme ref
* fix: change main branch to master, spelling and getting help url
…165)

Part of openedx/axim-engineering#23

This updates the `@edx/brand` alias to point to the `brand-openedx` package at
the `openedx` scope. This does not impact imports because this package is used
via an alias.
@bra-i-am bra-i-am requested a review from dcoa November 9, 2023 21:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@55a0ddb). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   83.01%           
=========================================
  Files             ?       46           
  Lines             ?      683           
  Branches          ?      132           
=========================================
  Hits              ?      567           
  Misses            ?      116           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* feat: babel-plugin-react-intl to babel-plugin-formatjs migration

* fix: upgraded frontend-build to fix security issue
@bra-i-am bra-i-am merged commit 7a299eb into eduNEXT:master Nov 15, 2023
@bra-i-am bra-i-am changed the title [improve][fork] Update fork with lastest changes in upstream (Olive & Palm) [improve][fork] Update fork with lastest changes in upstream Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.