forked from openedx/frontend-app-communications
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][fork] Update fork with lastest changes in upstream #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns into Ali-Abbas/react-router-upgrade
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Only a single change related to the `LMS_BASE_URL` setting was required. [1] openedx/frontend-platform#335
* refactor: migrate off paragon modal deprecated component * refactor: migrate off paragon modal deprecated component * refactor: resource the close button string * refactor: remove extra file * refactor: add message in messages file
Co-authored-by: arbrandes <[email protected]>
The default behavior of the TinyMCE editor is to rewrite links that share the same domain as the component to be relative to that path. Relative URLs will never work in email contents, so they _always_ need to be absolute URLs. This adds the configuration settings for `relative_urls` and `remove_script_host` in TinyMCE to always be false, enabling it to always use absolute URLs. See [here](https://www.tiny.cloud/docs/configure/url-handling/) for reference.
Adds a couple of missing features for proper runtime configuration: 1. Favicon runtime configuration support via react-helmet 2. Placeholder values for APP_ID and MFE_CONFIG_API_URL in the sample .env files
Co-authored-by: arbrandes <[email protected]>
* feat: update react & react-dom to v17 * build: update paragon version * refactor: updated edx packages --------- Co-authored-by: mashal-m <[email protected]>
Co-authored-by: justinhynes <[email protected]>
* docs: readme updated with frontend-template-app readme ref * fix: change main branch to master, spelling and getting help url
…ns into Ali-Abbas/react-router-upgrade
feat: upgrade react router to v6
…165) Part of openedx/axim-engineering#23 This updates the `@edx/brand` alias to point to the `brand-openedx` package at the `openedx` scope. This does not impact imports because this package is used via an alias.
Update browserslist DB
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage ? 83.01%
=========================================
Files ? 46
Lines ? 683
Branches ? 132
=========================================
Hits ? 567
Misses ? 116
Partials ? 0 ☔ View full report in Codecov by Sentry. |
* feat: babel-plugin-react-intl to babel-plugin-formatjs migration * fix: upgraded frontend-build to fix security issue
bra-i-am
changed the title
[improve][fork] Update fork with lastest changes in upstream (Olive & Palm)
[improve][fork] Update fork with lastest changes in upstream
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the fork of this MFE with the lastest changes in upstream
https://edunext.atlassian.net/browse/DS-722