chore: update requirements #24
Conversation
| @@ -16,7 +16,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.8", "3.11", "3.12"] | |||
| python-version: ["3.11", "3.12"] | |||
There was a problem hiding this comment.
Since we're dropping the tests for Python 3.8, and we can no longer guarantee compatibility with Quince, should we bump the version, add an entry to the changelog, and update the compatibility table?
There was a problem hiding this comment.
This plugin follows the tutor versioning convention, so this version (v17.x.x) doesn't necessarily support quince, although no significant changes have been made for a while. This makes me question if this plugin (edit: service) should follow the same convention that demands a new version each release cause we've been using the same for a while.
Now that Maga mentioned the compatibility table, can we update it to reflect the current plugin (edit: service) state?
There was a problem hiding this comment.
Reminder that this is not a Tutor plugin, this is essentially an IDA, tutor-contrib-codejail is the one that follows the Tutor versioning scheme. The actual plugin uses the compatible code of codejailservice for each release.
We decided to change the versioning scheme in redwood (see: #22). What should happen is that a new sumac branch is created, tutor-contrib-codejail builds using that branch until the release is ready and after that we tag sumac.1. I don't think the compatibility table in this repo is useful and I would rather remove it.
One thing that can be improved though, we should tag the other point-releases when they are ready.
There was a problem hiding this comment.
Oh, sorry. I edited my comment so it references the service instead.
I wasn't aware of the change in the versioning scheme. Should we remove the service releases to make it less confusing?
There was a problem hiding this comment.
If it makes sense, we can leave them up for history reasons, but it'd be good to drop the compatibility table that reference that release convention.
| @@ -16,7 +16,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.8", "3.11", "3.12"] | |||
| python-version: ["3.11", "3.12"] | |||
There was a problem hiding this comment.
This plugin follows the tutor versioning convention, so this version (v17.x.x) doesn't necessarily support quince, although no significant changes have been made for a while. This makes me question if this plugin (edit: service) should follow the same convention that demands a new version each release cause we've been using the same for a while.
Now that Maga mentioned the compatibility table, can we update it to reflect the current plugin (edit: service) state?
In addition to updating the requirements we also removed the pin to the codejail library. We also remove support/testing for python3.8
MoisesGSalas
force-pushed
the
mgs/update-requirements
branch
from
2203393 to
94fba99
Compare
This updates the normal requirements.
Additionally we remove the pin in the
codejaillibrary. We should instead keep it in sync with edx-platform.