Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support modbus ascii mode #94

Closed
wants to merge 1 commit into from

Conversation

bretagne-peiqi
Copy link

@bretagne-peiqi bretagne-peiqi commented Oct 30, 2019

Fix #81

@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #94 into master will decrease coverage by 0.48%.
The diff coverage is 35.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #94      +/-   ##
=========================================
- Coverage   45.88%   45.4%   -0.49%     
=========================================
  Files           6       6              
  Lines         523     588      +65     
=========================================
+ Hits          240     267      +27     
- Misses        247     275      +28     
- Partials       36      46      +10
Impacted Files Coverage Δ
internal/driver/modbusclient.go 0% <0%> (ø) ⬆️
internal/driver/config.go 61.83% <52.72%> (-4.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51007ad...c31dbfe. Read the comment docs.

@bretagne-peiqi
Copy link
Author

@cloudxxx8 Hi, please help review, thanks.

@cloudxxx8
Copy link
Member

sorry, we are busy on fuji release recently. this feature will be targeting to the next release, geneva.
I will review the code after settle down fuji. Do you know any simulator is easy to use for testing Modbus ascii? Thanks.

@cloudxxx8 cloudxxx8 requested a review from weichou1229 December 3, 2019 03:33
@weichou1229
Copy link
Member

@bretagne-peiqi
Could you add more detail info to test the Modbus ascii?
Because this is a new feature, please provide the following information:

  • how to set up a simulator
  • set up a device profile
  • create a device

@cloudxxx8
Copy link
Member

close this PR due to no activity

@cloudxxx8 cloudxxx8 closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: suport ascii mode
4 participants