Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick feedback #1

Open
dimakuv opened this issue May 7, 2021 · 0 comments
Open

Quick feedback #1

dimakuv opened this issue May 7, 2021 · 0 comments

Comments

@dimakuv
Copy link

dimakuv commented May 7, 2021

  1. The Coordinator performs attestation on the TensorFlow Serving application running on SGX using Graphene, and provides the application with secrets defined by the Marblerun manifest.
  2. The Administrator encrypts a pre-trained model and uplodas it to Kubernetes file storage

I would swap these two steps. It makes more logical sense to first upload the model to the storage, and then spawn & attest the TensorFlow app. (Also should change the numbering on the diagram.)

  1. The Administrator encrypts a pre-trained model and uplodas it to Kubernetes file storage

Typo: uploads.

Get Marbleruns intermediate certificate to connect to the model server

Typo: Marbelrun's.

https://github.com/edgelesssys/graphene-tensorflow-demo/blob/master/tensorflow.dockerfile#L62

You seem to use a slightly outdated version of Graphene. We now moved (well, in the process of moving) to the Meson build & install. In particular, Graphene is now able to install itself (only the needed binaries and related files) either under /usr/local/ (default path) or in your specific path via --prefix. See https://graphene.readthedocs.io/en/latest/building.html#id1 and especially https://graphene.readthedocs.io/en/latest/building.html#additional-build-options.

I didn't check the non-Graphene files and commands (like Kubernetes files), but overall looks correct. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant