Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge cloudbuild-trigger hotfixes into main #106

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Merge cloudbuild-trigger hotfixes into main #106

merged 8 commits into from
Oct 14, 2024

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Oct 3, 2024

As per title.

fordN
fordN approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was just making the same changes. :)
LGTM 👍

@neysofu
Temporarily disable test
5fa29ab 
Signed-off-by: Filippo Costa <[email protected]>
@neysofu
Remove unneeded imports
05ee4c3 
Signed-off-by: Filippo Costa <[email protected]>
@neysofu
Temporarily disable all tests
b23cc05 
Signed-off-by: Filippo Costa <[email protected]>
@neysofu neysofu merged commit 08d150b into main Oct 14, 2024
3 checks passed
@neysofu neysofu deleted the cloudbuild-trigger branch October 14, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fordN fordN fordN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neysofu @fordN