Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indexer-selection): make indexer-selection generic over candidae metadata #41

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Jun 4, 2024

Make the indexer-selection::Candidate type generic over candidate metadata, i.e., indexing ID and the indexing metadata (URL, largest allocation address, TAP support, etc.).

@LNSD LNSD requested a review from Theodus June 4, 2024 11:39
@LNSD LNSD self-assigned this Jun 4, 2024
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of removing dependencies by making a generic metadata field. But it seems incorrect to only use the indexer address for the ID, since that would it make it impossible to distinguish candidates across subgraph versions.

@LNSD
Copy link
Contributor Author

LNSD commented Jun 4, 2024

I like the idea of removing dependencies by making a generic metadata field. But it seems incorrect to only use the indexer address for the ID, since that would it make it impossible to distinguish candidates across subgraph versions.

The idea will be to use the IndexerId type (which includes both) as the id field type.

indexer-selection/src/test.rs Outdated Show resolved Hide resolved
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I misunderstood part of the changes

indexer-selection/src/test.rs Outdated Show resolved Hide resolved
@LNSD LNSD force-pushed the lnsd/feat-isa-candidate-generic branch from 3b9ed69 to f23ba4e Compare June 4, 2024 12:56
@LNSD LNSD merged commit 1d6db83 into main Jun 4, 2024
3 checks passed
@LNSD LNSD deleted the lnsd/feat-isa-candidate-generic branch June 4, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants