Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to add ignored directories in editor and commandlet #2

Open
eddiebeazer opened this issue Feb 10, 2023 · 5 comments
Open
Assignees

Comments

@eddiebeazer
Copy link
Owner

No description provided.

@eddiebeazer eddiebeazer self-assigned this Oct 10, 2023
@d-franklin
Copy link

Thanks for your work on getting this working with UE5.

I'm wondering if ignoring folders is an option in the current version or it's still a work in progress?

@eddiebeazer
Copy link
Owner Author

@d-franklin I think it's still possible. I have my own edited version of the plugin where I'm doing it manually. I believe the only thing stopping me from adding it to the main branch is just that I need to figure out how to add a menu to the Project Settings UI so each game can specify and save the settings in a .ini.

When I review your PR I'll try to take a look at it. I believe it shouldn't be all too bad considering that there is already UI options for specifying the type of linter

@d-franklin
Copy link

@d-franklin I think it's still possible. I have my own edited version of the plugin where I'm doing it manually. I believe the only thing stopping me from adding it to the main branch is just that I need to figure out how to add a menu to the Project Settings UI so each game can specify and save the settings in a .ini.

Even having a manual option would be nice. The setting menu is preferable but any way to exclude folders is good, especially when using marketplace assets since the linter will throw a fit.

When I review your PR I'll try to take a look at it. I believe it shouldn't be all too bad considering that there is already UI options for specifying the type of linter

RE my PR. It's nothing special, it just removes one line (in the command line version) that is adding the Game folder as the default scan folder, it's being run twice when it only needs to run once. But in it's current state doesn't effect anything.

@eddiebeazer
Copy link
Owner Author

eddiebeazer commented Sep 6, 2024 via email

@d-franklin
Copy link

Do you run Linter with the cli or in the editor? When I added the manual paths I did it for cli usage for my CI workflow.

Both. The editor allows for correcting mistakes before they get to source control and/or CI and the cli catches human error. There is always the option of running the cli before commits to SC but the editor just makes life easier.

I’m fairly busy the next week or two but I’ll see if I can get to this by the end of the month.

Cool, no rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants