Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: GenIncShockModel.ipynb should compare IndShockConsumerType solution in levels #1504

Open
llorracc opened this issue Oct 18, 2024 · 3 comments
Labels
Expertise: Econ-ARK (basic) Doable by someone with basic working familiarity with HARK good first issue Simple first issue for new contributors. Priority: Low Type: Enhancement

Comments

@llorracc
Copy link
Collaborator

The GenIncShockModel notebook solves (among other things) for a model in which the "serial correlation" of the persistent shock is 1.0, then shows some results.

It would be great to illustrate the point that that model's solution is (or should be) identical to the solution to the IndShockConsumerType model with the same parameters. That would both provide a test of the two solution methods and help make very clear how to interpret the solution to the IndShockConsumerType model.

@llorracc llorracc added Type: Enhancement good first issue Simple first issue for new contributors. Priority: Low Expertise: Econ-ARK (basic) Doable by someone with basic working familiarity with HARK labels Oct 18, 2024
@mnwhite
Copy link
Contributor

mnwhite commented Oct 18, 2024 via email

@mnwhite
Copy link
Contributor

mnwhite commented Nov 21, 2024

I just verified, it's in /examples/GenIncProcessModel/GenIncProcessModel.ipynb ... This is the figure it produces:

image

@mnwhite
Copy link
Contributor

mnwhite commented Nov 21, 2024

It includes a comparison (to ConsIndShock) right below that, and has this explanation:

image

I think this can be closed as already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expertise: Econ-ARK (basic) Doable by someone with basic working familiarity with HARK good first issue Simple first issue for new contributors. Priority: Low Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants