Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full testing including S3 testing with min.io #6

Open
noamross opened this issue Nov 27, 2023 · 0 comments
Open

Full testing including S3 testing with min.io #6

noamross opened this issue Nov 27, 2023 · 0 comments

Comments

@noamross
Copy link
Collaborator

noamross commented Nov 27, 2023

This is a complex set up - we have two online services, (AWS) S3 and GitHub, and both git hashes and S3 version IDs are not predictable (they may be deterministic but integrate seeds and timestamps). S3 we can imitate with a local min.io server, but GH mocking will be tough, as we'd have to artificially generate mocks based on hashes generated in the example git repos. So it may make more sense to push the example repo to GitHub and test directly against it, or push up to test and then generate mocks from that each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant