Fix problems due to differing prefixes in S3 stores #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the paths to objects in S3 could differ due to different prefix approaches across targets versions (ropensci/targets#1123). After downloading a target from S3 or elsewhere, we don't assume it is under a proper store path. Rather, on reading we create a temporary store (tempfile/objects/downloaded_file), which is actually a symlink to the object in the cache. So the path to the object is now irrelevant.
@emmamendelsohn, since you have git2r installed already, try this with
remotes::install_github(ecohealthalliance/relic#11)