Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems due to differing prefixes in S3 stores #11

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

noamross
Copy link
Collaborator

@noamross noamross commented Nov 28, 2023

This PR fixes an issue where the paths to objects in S3 could differ due to different prefix approaches across targets versions (ropensci/targets#1123). After downloading a target from S3 or elsewhere, we don't assume it is under a proper store path. Rather, on reading we create a temporary store (tempfile/objects/downloaded_file), which is actually a symlink to the object in the cache. So the path to the object is now irrelevant.

@emmamendelsohn, since you have git2r installed already, try this with remotes::install_github(ecohealthalliance/relic#11)

@codecov-commenter
Copy link

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (3c98c2c) 25.00% compared to head (02d502c) 24.33%.

❗ Current head 02d502c differs from pull request most recent head d021db7. Consider uploading reports for the commit d021db7 to get more accurate results

Files Patch % Lines
R/tar_read_version.R 0.00% 26 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   25.00%   24.33%   -0.67%     
==========================================
  Files          15       15              
  Lines         404      415      +11     
==========================================
  Hits          101      101              
- Misses        303      314      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmamendelsohn
Copy link

Awesome, works now

@noamross noamross merged commit 5bb5526 into main Nov 28, 2023
5 checks passed
@noamross noamross deleted the fix-store-path branch November 28, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants