Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor AdHocMessageRoutingBuilder #433

Merged
merged 28 commits into from
Nov 19, 2024
Merged

feat: refactor AdHocMessageRoutingBuilder #433

merged 28 commits into from
Nov 19, 2024

Conversation

FunKuchen
Copy link
Contributor

@FunKuchen FunKuchen commented Nov 12, 2024 •
edited by kschrab
Loading

Description

  • This PR refactors methods in the AdHocMessageRoutingBuilder to our new standards
  • Creates new methods for configuring hops, channel, routing protocol and destination
  • Adjusts Tests and other usages to these new methods

Issue(s) related to this PR

  • Resolves part of internal issue 917

Affected parts of the online documentation

  • Changes needed on communication documentation on website
  • Adressed in internal issue 911

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

FunKuchen and others added 23 commits June 19, 2024 14:39
@FunKuchen
fix(workshop): Enabled color changing of externally added vehicles in…
66c4b20 
… SUMO
@FunKuchen
Merge remote-tracking branch 'upstream/main'
795b2ce
@FunKuchen
Merge remote-tracking branch 'upstream/main'
0a11ba1 
Update
@FunKuchen
Merge remote-tracking branch 'upstream/main'
f09805c
@FunKuchen
Merge remote-tracking branch 'refs/remotes/upstream/main'
dfaad7e
@FunKuchen
Merge remote-tracking branch 'upstream/main'
4c229c8
@FunKuchen
Merge remote-tracking branch 'upstream/main'
b9c9274
@FunKuchen
feat: Refactored AdHoc message routing
ed0bd47
@FunKuchen
fix: reverted accidental cell change
2973bd3
@FunKuchen
fix: fixed weather app test
648011c
@FunKuchen
Revert "fix: fixed weather app test"
745e90e 
This reverts commit 648011c.
@FunKuchen
feat: Refactored AdHoc message routing
7d227c7
@FunKuchen
feat: Added hops argument for builder
46f6e84
@FunKuchen
feat: Fix streaming
7510adf
@hoelger @FunKuchen
fix: show correct icons in barnim scenario (eclipse#422)
db2762f
@hoelger @FunKuchen
docs: link the new documentation page in the README (eclipse#421)
51412b2
@kschrab @FunKuchen
build: store etc-files in mosaic-starter and copy them to bundle (ecl…
5783b64 
…ipse#423)

* build: store etc-files in mosaic-starter and copy them to bundle and integration tests
* clean: remove unnecessary properties from copy-resources definition
@kschrab @FunKuchen
feat(sumo): support sumo 1.21.0 (eclipse#424)
3337498 
* ci: use SUMO 1.21.0 for testing
* feat(sumo): support SUMO 1.21.0

Added hint, that SUMO_HOME/bin must be present in the PATH variable. Pre-loading some libraries is not required anymore then.
@hoelger @FunKuchen
fix: remove VSimRTI from WebVisualizer (eclipse#426)
d7f7609
@hoelger @FunKuchen
feat: run windows-mosaic with wsl-ns3 (eclipse#425)
aebf82b 
* refactor: don't use this whenever possible
@kschrab @FunKuchen
feat(sns): support multi-hop unicast for topological and geographical…
bf33487 
… routing (eclipse#428)

* feat(sns): cleanup, minor performance improvement for flooding (early exit if flooding could not be progressed)
@kschrab @FunKuchen
feat: introducing SensorModule to provide access to environmental eve…
c14ef1e 
…nts (eclipse#420)

* feat: introducing SensorModule to provide access to environmental events
* feat(application): allow registration of callback for lidar sensor module
* feat(application): re-use Perceptive interface for accessing new sensor modules
@FunKuchen
Merge branch 'eclipse:main' into 917-refactor-ad-hoc-message-routing
7888d66
hoelger
hoelger suggested changes Nov 13, 2024
View reviewed changes
...affic-light-communication/src/main/java/org/eclipse/mosaic/app/tutorial/RoadSideUnitApp.java Outdated Show resolved Hide resolved
...ects/src/main/java/org/eclipse/mosaic/lib/objects/addressing/AdHocMessageRoutingBuilder.java Outdated Show resolved Hide resolved
...ects/src/main/java/org/eclipse/mosaic/lib/objects/addressing/AdHocMessageRoutingBuilder.java Outdated Show resolved Hide resolved
...ects/src/main/java/org/eclipse/mosaic/lib/objects/addressing/AdHocMessageRoutingBuilder.java Outdated Show resolved Hide resolved
...ects/src/main/java/org/eclipse/mosaic/lib/objects/addressing/AdHocMessageRoutingBuilder.java Show resolved Hide resolved
...ects/src/main/java/org/eclipse/mosaic/lib/objects/addressing/AdHocMessageRoutingBuilder.java Show resolved Hide resolved
...ects/src/main/java/org/eclipse/mosaic/lib/objects/addressing/AdHocMessageRoutingBuilder.java Show resolved Hide resolved
...ects/src/main/java/org/eclipse/mosaic/lib/objects/addressing/AdHocMessageRoutingBuilder.java Outdated Show resolved Hide resolved
...objects/src/test/java/org/eclipse/mosaic/lib/objects/v2x/AdHocMessageRoutingBuilderTest.java Outdated Show resolved Hide resolved
@FunKuchen
Copy link
Contributor Author

@kschrab @hoelger @rprotzmann Open question: Should we rename the destination types in the DestinationType enum? Currently they reflect our old naming scheme.
And how could we name them more suitable?
This would also affect changes in the documentation on the website and in ns-3 configuration files.
grafik
(Havn't changed it in this commit, therefore could't tag here)

@kschrab
Copy link
Contributor

kschrab commented Nov 19, 2024

@kschrab @hoelger @rprotzmann Open question: Should we rename the destination types in the DestinationType enum? Currently they reflect our old naming scheme.

We should discuss this in a separate PR and leave it for now.

kschrab
kschrab reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@kschrab kschrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor issues

...ects/src/main/java/org/eclipse/mosaic/lib/objects/addressing/AdHocMessageRoutingBuilder.java Outdated Show resolved Hide resolved
fed/mosaic-sns/src/test/java/org/eclipse/mosaic/fed/sns/ambassador/SnsAmbassadorTest.java Outdated Show resolved Hide resolved
@kschrab kschrab self-assigned this Nov 19, 2024
@kschrab kschrab added clean-up Aesthetically improving code enhancement New feature or request labels Nov 19, 2024
@kschrab kschrab changed the title feat: Refactor AdHocMessageRoutingBuilder feat: refactor AdHocMessageRoutingBuilder Nov 19, 2024
@kschrab kschrab self-requested a review November 19, 2024 09:43
@kschrab kschrab merged commit 4a4a335 into eclipse:main Nov 19, 2024
5 checks passed
@FunKuchen FunKuchen deleted the 917-refactor-ad-hoc-message-routing branch November 19, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoelger hoelger hoelger requested changes

@kschrab kschrab kschrab approved these changes

Assignees

@kschrab kschrab

Labels
clean-up Aesthetically improving code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FunKuchen @kschrab @hoelger